/freebsd/sys/dev/e1000/ |
H A D | if_em.c | 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558
|
/freebsd/sys/dev/igc/ |
H A D | if_igc.c | 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558
|
/freebsd/sys/dev/ixgbe/ |
H A D | if_ix.c | 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558
|
/freebsd/sys/dev/mgb/ |
H A D | if_mgb.c | 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558
|
/freebsd/sys/net/ |
H A D | ifdi_if.m | 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558 725e4008 Thu Aug 24 20:42:23 GMT 2023 Kevin Bowling <kbowling@FreeBSD.org> iflib: invert default restart on VLAN changes
In rS360398, a new iflib device method was added to opt out of VLAN events needing an interface reset.
I am switching the default to not requiring a restart for: * VLAN events * unknown events
After fixing various bugs, I do not think this would be a common need of hardware and it is undesirable from the user's perspective causing link flaps and much slower VLAN configuration. Currently, there are no other restart events besides VLAN events, and setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.
markj points out this could cause churn in the other direction; I will solve that problem with an event registration system as he mentions in the review should we need it in the future.
These drivers will opt into restart and need further inspection or work: * ixv (needs code audit, 61a8231 fixed principal issue; re-init probably not necessary) * axgbe (needs code audit; re-init probably not necessary) * iavf - (needs code audit; interaction with Malicious Driver Detection mentioned in rS360398) * mgb - no VLAN functions are currently implemented. Left a comment.
MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D41558
|